[ZEPPELIN-958] Support syntax highlight for python and r interpreter#966
[ZEPPELIN-958] Support syntax highlight for python and r interpreter#966minahlee wants to merge 1 commit intoapache:masterfrom
Conversation
|
LGTM |
|
@felixcheung Could you please tell me your idea in details? Basically I agree with you, but I'm not good at frontend, I don't know whether the feature can be adopted dynamically or not. If it's possible, you could that feature into Interpreter scope. It seems nice. |
|
BTW, this PR looks good to me. We can discuss @felixcheung's issue after merging this PR. |
|
Looks great to me, let's merge as a short term solution. And yes, as @felixcheung mentioned - in a mid\long term, it would be great for interpreter to encapsulate this knowledge! |
|
Merging if there is no further discussion |
|
right, I think that can be added to interpreterSettings and checked on the frontend similar to this: |
|
That was only to map the list of interpreter to the language though. To figure out which interpreter is active in the interpreter right now we have regex to match "%something" at the beginning which won't work for the default interpreter at all. |

What is this PR for?
Support syntax highlight for python and r interpreter
What type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-958
Screenshots (if appropriate)
Before

After

Before

After

Questions: